Top connectors #148
Top connectors #148
Conversation
| filename={`Top Connector Weekly Report (${lastWeek}).tsv`} | ||
| src='/api/partners/top-connector' | ||
| > | ||
| Optimism |
| const lastWeek = getLastWeek(); | ||
| const rows = await getScoutsForTopConnectorPartner({ week: lastWeek }); | ||
|
|
||
| return respondWithTSV(rows, `partners-export_supersim_${lastWeek}.tsv`); |
There was a problem hiding this comment.
update the filename: "export_top_connectors" and i dont think u need to export a week at a time. it coould just be an export for the last 14 days or soemthing?
| const events = await prisma.builderEvent.findMany({ | ||
| where: { | ||
| type: 'top_connector', | ||
| week |
There was a problem hiding this comment.
mentioned above but i think this report should always give you the most recent data available at least. or maybe do this week and last week?
| }) { | ||
| await prisma.builderEvent.create({ | ||
| data: { | ||
| bonusPartner: 'top-connector', |
There was a problem hiding this comment.
this is not what bonusPartner was intended for. it should only be for real partners that for example live on the partners page
There was a problem hiding this comment.
if we dont need cron i rather we not use it. some extra queries is way easier to manage and follow than a new "process" (even if its built on an existing service) running in production. i don't see why admin can't just calculate the top connectors on the fly. And I think this also means we dont need to extend builder event
TODO:
[ ] move Daily Claim in sidebar
[ ] Tests