Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-export Network.Wai.Parse.ParseRequestBodyOptions #394

Conversation

pbrinkmeier
Copy link
Contributor

Does what it says, addresses #387

Sorry for spamming you with PR's, got some time on my hand and am a fan of the project so I'd like to contribute.

@pbrinkmeier pbrinkmeier force-pushed the chore/dont-export-parserequestbodyoptions branch from ab36f4b to 38c1a92 Compare April 6, 2024 00:05
@pbrinkmeier
Copy link
Contributor Author

Fixed the conflict in changelog.md

@ocramz ocramz self-requested a review April 7, 2024 06:02
Copy link
Collaborator

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, 👍 ! Just a minor thing with the changelog entry.

changelog.md Outdated Show resolved Hide resolved
@ocramz ocramz self-requested a review April 7, 2024 17:42
Copy link
Collaborator

@ocramz ocramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@ocramz ocramz merged commit 8a55318 into scotty-web:master Apr 7, 2024
6 checks passed
@pbrinkmeier pbrinkmeier deleted the chore/dont-export-parserequestbodyoptions branch April 8, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants