Livetime interface updates #78

ErikBorra · 2018-04-30T14:27:35Z

This pull request includes the timingserver layout from @basdelfos (up til #67f5736), including:

a nicer layout
pi temperature
shutdown and restart button for pi

I have further tweaked it by

using the full width of the window instead of Bas' default 900px
adding a clearfix for lap times so that nodes 4 to 8 stay on the same height
adding all fpv frequencies as a drop down

…and full width instead of 900px

punkkills · 2018-05-01T12:41:51Z

Hey @ErikBorra, I'll give this change a more in depth view when i have some time. Out of curiosity, what value do you find that these changes add? When I built this page, the intent was a place to test out the Socket.IO API as I was working with Cory for the Livetime integration. I didn't really intend this page to be a long lived user facing UI. All of these values are easily accessible from LiveTime. If the value is the shutdown and temperature reading, those are things better requested from LiveTime, IMO.

ErikBorra · 2018-05-01T13:17:08Z

Hi @punkkills,

thanks for your feedback. There are a few uses for the page:

shutdown/restart buttons
easier monitoring of correct calibration settings
monitoring the logs
rssi graphs display (livetime doesn't show rssi values)
better looking interface for future led control integration

scottgchin · 2018-05-01T13:28:50Z

I agree with @punkkills that this page shouldn't be used to change the timer settings, as these are available through Livetime. But I think there are items that are helpful like the graphs. I was planning on officially adding those at some point (it was already there, just not linked). I also want to add the LED controls since LiveTime has limited commands.

What if we do both? Remove the timer settings, and reconfigure the page to show the graphs and the LED controls?

ErikBorra · 2018-05-01T13:42:23Z

Why should the timer settings not be changed through that page? It doesn't hurt, does it? Actually, I find it easier to change the settings via the page, as you get the direct visual feedback of the three coloured bars (rssi peak, calibration offset, current rssi) below.

basdelfos · 2018-05-01T19:44:15Z

I have an updated version of my original version of this page which also displays the looptime per node and also displays the input voltage (handy when using a lipo to power the Delta 5 or when using PoE adapter with very long UTP cable). The input voltage requires a hardware mod with voltage divider and an updated sketch on node 4.

I can upload the changes to github when interested.

punkkills

I don't have time right now, but i'd like to pull this to my machine and give it a run. My two main comments:

This should still work on windows for testing purposes. The platform specific stuff seems like it will cause problems with that.
In general, I would prefer to make specific requests for livetime functionality over enhancing (and maintaining) the timing server web page. You mention it is easier to make changes through the page. Let's identify the issues with the livetime integration and request to make it better. I'm sure we can ask Cory for the shutdown, temperature and voltage UIs.

punkkills · 2018-05-02T03:07:15Z

src/delta5interface/BaseHardwareInterface.py

@@ -10,6 +12,12 @@ def __init__(self):
        self.start_time = datetime.now()
        self.filter_ratio = 50

+    def get_cpu_temperature(self):
+        """get cpu temperature using vcgencmd"""
+        process = Popen(['vcgencmd', 'measure_temp'], stdout=PIPE)


BaseHardwareInterface is designed to be a platform agnostic interface layer. MockInterface is a subclass and is used for testing on windows. I assume this is pi specific?

Yes, this is pi (linux) specific. Should we make a PiInterface to move it out of BaseHardwareInterface?

punkkills · 2018-05-02T03:08:20Z

src/timingserver/server.py

@@ -25,6 +26,63 @@

 hardwareInterface = get_hardware_interface()

+# frequencies
+band_channel_frequency = []


Why not just embed the frequencies in the index.html?

Makes a lot of sense. I added it to server.py, as the delta5server does something similar at L952

ErikBorra · 2018-05-02T07:26:04Z

Hi @punkkills,

thanks so much for your time and feedback. I'm sure many would love to have the LiveTime integration be better.

From the top of my head, the following would be great to have in LiveTime:

shutdown / restart
temperature
voltage reading (as @basdelfos has implemented)
indicators for current rssi, peak rssi and calibration offset
a button to 'copy event frequencies' like with the 8-way laprf

Currently LiveTime only sends a message to delta 5 when a race has started (by calling reset_calibration in server.py). For integration with the led functionality, It'd be awesome if LiveTime could also indicate to delta5:

when there was a false start or end of race
the colours associated to a specific frequency

Last, but not least, if @lephiloux 's per node tuning was added to @scottgchin's repo (see this commit]), it'd be great if we could do that via LiveTime as well.

Shall I open an issue to discuss this, instead of discussing this here?

basdelfos · 2018-05-02T07:40:40Z

I've just merged the voltage and looptime monitoring to master of my fork.
https://github.com/basdelfos/delta5_race_timer

lephiloux · 2018-05-02T14:17:52Z

It’s as you want , issue or here both are fine for me ;-) Envoyé de mon iPhone

…

Le 2 mai 2018 à 09:26, Erik Borra ***@***.***> a écrit : Hi @punkkills, thanks so much for your time and feedback. I'm sure many would love to have the LiveTime integration be better. From the top of my head, the following would be great to have in LiveTime: shutdown / restart temperature voltage reading (as @basdelfos has implemented) indicators for current rssi, peak rssi and calibration offset a button to 'copy event frequencies' like with the 8-way laprf Currently LiveTime only sends a message to delta 5 when a race has started (by calling reset_calibration in server.py). It'd be awesome if LiveTime could also indicate to delta5: when a race has completed the colours associated to a specific frequency (for integration with the led functionality) Last, but not least, if @lephiloux 's per node tuning was added to @scottgchin's repo (see this commit]), it'd be great if we could do that via LiveTime as well. Shall I open an issue to discuss this, instead of discussing this here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

klaasnicolaas · 2019-01-17T11:58:27Z

src/timingserver/server.py

+    os.system("sudo shutdown now")
+
+@socketio.on('restart_pi')
+def on_shutdown_pi():


must this be on_restart_pi() ?

klaasnicolaas · 2019-01-17T12:10:28Z

src/timingserver/templates/graphs.html

@@ -7,6 +7,8 @@
    <script src="./static/chartjs/Chart.bundle.js"></script>
    <script type="text/javascript" src="./static/jquery/jquery-3.1.1.min.js"></script>
    <script type="text/javascript" src="./static/socket.io/1.3.5/socket.io.min.js"></script>
+    <link rel="stylesheet" href="./static/bootstrap-3.3.7/css/bootstrap.min.css"></link>
+    <script type="text/javascript" src=".//static/bootstrap-3.3.7/js/bootstrap.min.js"></script>


Suggested change

<script type="text/javascript" src=".//static/bootstrap-3.3.7/js/bootstrap.min.js"></script>

<script type="text/javascript" src="./static/bootstrap-3.3.7/js/bootstrap.min.js"></script>

One / too much?

ErikBorra and others added 19 commits February 27, 2018 21:51

instructions on putting together delta5 with PCB V2

3153727

small textual updates

0612070

small textual updates

cd7ca6c

small textual updates

9633146

added software links

2c79b22

small textual updates

ecfeb4e

small textual updates

3aa9544

instructions on putting together delta5 with PCB V2

7646614

Merge branch 'master' of github.com:ErikBorra/delta5_race_timer

5387287

added xt60 link to banggood

e9e61bf

instructions on putting together delta5 with PCB V2

529379d

Merge branch 'master' of github.com:ErikBorra/delta5_race_timer

6aaa8f6

instructions on putting together delta5 with PCB V2

adffa26

Merge branch 'master' of github.com:ErikBorra/delta5_race_timer

4f5b8a2

added rpi wiring diagram and user guide

e3fb31d

livetime layout from basdelfos (67f5736) with clearfix for lap times …

0ce764d

…and full width instead of 900px

Merge remote-tracking branch 'upstream/master'

1e95d5d

added channel select dropdown

59b0126

moving pcb v2 doc out of the way

c67a6b7

punkkills reviewed May 2, 2018

View reviewed changes

klaasnicolaas reviewed Jan 17, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Livetime interface updates #78

Livetime interface updates #78

ErikBorra commented Apr 30, 2018

punkkills commented May 1, 2018

ErikBorra commented May 1, 2018

scottgchin commented May 1, 2018

ErikBorra commented May 1, 2018

basdelfos commented May 1, 2018

punkkills left a comment

punkkills May 2, 2018

ErikBorra May 2, 2018

punkkills May 2, 2018

ErikBorra May 2, 2018

ErikBorra commented May 2, 2018 •

edited

Loading

basdelfos commented May 2, 2018

lephiloux commented May 2, 2018 via email

klaasnicolaas Jan 17, 2019

klaasnicolaas Jan 17, 2019

	<script type="text/javascript" src=".//static/bootstrap-3.3.7/js/bootstrap.min.js"></script>
	<script type="text/javascript" src="./static/bootstrap-3.3.7/js/bootstrap.min.js"></script>

Livetime interface updates #78

Are you sure you want to change the base?

Livetime interface updates #78

Conversation

ErikBorra commented Apr 30, 2018

punkkills commented May 1, 2018

ErikBorra commented May 1, 2018

scottgchin commented May 1, 2018

ErikBorra commented May 1, 2018

basdelfos commented May 1, 2018

punkkills left a comment

Choose a reason for hiding this comment

punkkills May 2, 2018

Choose a reason for hiding this comment

ErikBorra May 2, 2018

Choose a reason for hiding this comment

punkkills May 2, 2018

Choose a reason for hiding this comment

ErikBorra May 2, 2018

Choose a reason for hiding this comment

ErikBorra commented May 2, 2018 • edited Loading

basdelfos commented May 2, 2018

lephiloux commented May 2, 2018 via email

klaasnicolaas Jan 17, 2019

Choose a reason for hiding this comment

klaasnicolaas Jan 17, 2019

Choose a reason for hiding this comment

ErikBorra commented May 2, 2018 •

edited

Loading