Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow valid Score specs without a containers section and support top level extensions #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astromechza
Copy link
Member

@astromechza astromechza commented Nov 19, 2024

We've been looking at how we can use Score to support slightly more abstract workloads and we've seen that the > 1 containers places somewhat of a limitation on what Score implementations can accept and transform and how teams can iterate and learn about Score. This coincides with the need to start supporting additional top level extensions on the spec:

apiVersion: score.dev/v1b1
metadata:
  name: example-workload-name123
x-my-extension:
  archive: http://example.com/binary.tgz
  variables:
    SOME_VAR: ${resources.example.thing}
resources:
  example:
    type: resource-type

@astromechza astromechza changed the title feat: allow 0 containers and containers without an image feat: allow 0 containers Nov 19, 2024
@astromechza astromechza changed the title feat: allow 0 containers feat: allow valid Score specs with zero containers Nov 19, 2024
@astromechza astromechza changed the title feat: allow valid Score specs with zero containers feat: allow valid Score specs without a containers section Nov 29, 2024
@astromechza astromechza changed the title feat: allow valid Score specs without a containers section feat: allow valid Score specs without a containers section and support top level extensions Nov 29, 2024
Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a little too permissive to add this to the score spec as stands. If experimentation is required, a new implementation can always be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants