Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow dot as separator in resource id #105

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: allow dot as separator in resource id #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2356d0
feat: allow dot as separator in resource id
astromechza Sep 11, 2024
1569fc3
fix: prevent labels ending with - in resource id
astromechza Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/score-full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,6 @@ resources:
data: here
resource-two2:
type: Resource-Two
resource-three:
resource.three:
type: Type-Three
id: shared-type-three
4 changes: 2 additions & 2 deletions score-v1b1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@
"pattern": "^[A-Za-z0-9][A-Za-z0-9-]{0,61}[A-Za-z0-9]$"
},
"id": {
"description": "An optional external Resource identifier. When two resources share the same type, class, and id, they are considered the same resource when used across related Workloads. The id must be a valid RFC1123 Label Name of up to 63 characters, including a-z, 0-9, '-' but may not start or end with '-'.",
"description": "An optional Resource identifier. The id may be up to 63 characters, including one or more labels of a-z, 0-9, '-' not starting or ending with '-' separated by '.'. When two resources share the same type, class, and id, they are considered the same resource when used across related Workloads.",
"type": "string",
"minLength": 2,
"maxLength": 63,
"pattern": "^[a-z0-9][a-z0-9-]{0,61}[a-z0-9]$"
"pattern": "^[a-z0-9]+(?:-+[a-z0-9]+)*(?:\\.[a-z0-9]+(?:-+[a-z0-9]+)*)*$"
},
"metadata": {
"description": "The metadata for the Resource.",
Expand Down
Loading