Added the Dockerfile for the score-k8s and release too #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
mathieu-benoit
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Thanks for your contribution!
I added 2 suggestions (that I auto-applied).
Also, to complete this PR, could you please take these below into account:
- Add build container step in
ci.yamllike inscore-compose: https://github.com/score-spec/score-compose/blob/main/.github/workflows/ci.yaml#L32-L36 - Uncomment this part in
dependabot.yml: https://github.com/score-spec/score-k8s/blob/main/.github/dependabot.yml#L11-L14
Signed-off-by: Mathieu Benoit <[email protected]>
Signed-off-by: Mathieu Benoit <[email protected]>
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
Added the container step in ci.yaml and fixed the bot
Signed-off-by: Mathieu Benoit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to fix #40
Description
Added the Dockerfile , and release.yml for making the score-k8s image
What does this PR do?
This PR main purpose is to make the docker image for the score-k8s like the rest
Types of changes
Checklist: