Go version and package version upgrade for issue #39 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Insomniac2904 <[email protected]>
Signed-off-by: Insomniac2904 <[email protected]>
Insomniac2904
force-pushed
the
go-version-upgrade-1
branch
from
95e4c74 to
10ae4ec
Compare
mathieu-benoit
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @Insomniac2904 , for your contribution, much appreciated!
This LGTM, CI/test https://github.com/score-spec/score-k8s/actions/runs/11315133712/job/31465943364?pr=41 is passing successfully.
|
@delca85, could you please give this a quick review in case we are missing anything here? Thanks! |
|
We should probably update the required go version in the README file as well. |
@Insomniac2904, please could you take this update into account before we merge your PR? Thanks! |
|
Actually, let me merge this PR, now approved, I'll deal with the minor update to do on the README.md in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #39
Upgraded the go version and packages version.