Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Service name now as the Workload, removing the -svc suffix + new annotation to override it k8s.score.dev/service-name #34

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Default Service name now as the Workload, removing the -svc suffix + new annotation to override it k8s.score.dev/service-name #34

merged 1 commit into from
Sep 7, 2024

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Sep 6, 2024 •
edited
Loading

  • Default Service name now as the Workload, removing the -svc suffix
  • New annotation to override it: k8s.score.dev/service-name

@mathieu-benoit mathieu-benoit mentioned this pull request Sep 6, 2024
Closed
@mathieu-benoit mathieu-benoit marked this pull request as draft September 6, 2024 14:22
@mathieu-benoit mathieu-benoit changed the title Default Service name now as the Workload + new annotation to override it Default Service name now as the Workload, removing the -svc suffix + new annotation to override it k8s.score.dev/service-name Sep 6, 2024
@mathieu-benoit mathieu-benoit marked this pull request as ready for review September 6, 2024 14:26
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

astromechza
astromechza approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mathieu-benoit !

@mathieu-benoit mathieu-benoit merged commit ed404d0 into main Sep 7, 2024
5 checks passed
@mathieu-benoit mathieu-benoit deleted the svc-name branch September 7, 2024 00:05
@mathieu-benoit mathieu-benoit mentioned this pull request Sep 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @astromechza