feat: function to normalize the spec #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
requested review from
astromechza,
delca85,
sujaya-sys and
mateuszjenek
astromechza
reviewed
Mar 20, 2024
astromechza
reviewed
Mar 20, 2024
README.md
Outdated
|
|
||
| var srcMap map[string]interface{} | ||
| if err = loader.ParseYAML(&srcMap, src); err != nil { | ||
| if err := loader.ParseYAML(&srcMap, src); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| var spec score.WorkloadSpec |
There was a problem hiding this comment.
We should also recommend a call to score-go/schema Validate() before calling map spec.
astromechza
reviewed
Mar 20, 2024
| ) | ||
|
|
||
| // Normalize normalizes the target Workload by: | ||
| // * embedding container file sources as content |
There was a problem hiding this comment.
nit pick: the only other normalisation I can think of so far is setting the protocol and target port in the services block if they aren't defined. Don't have to include them here, as most converters will be doing that by default anyway
There was a problem hiding this comment.
Yes, I wasn't really sure if we would add something in the future 🤔
astromechza
approved these changes
Mar 20, 2024
johanneswuerbach
force-pushed
the
normalize
branch
from
be5b1e4 to
5609a02
Compare
Signed-off-by: Johannes Würbach <[email protected]>
johanneswuerbach
force-pushed
the
normalize
branch
from
5609a02 to
2f2e139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of implementing common concepts like embedding files in each implementation, add a
Normalizefunction, which performs such operations.What does this PR do?
Move shared functionality (embedding files) into this library.
Types of changes
Checklist: