Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added oci example in score-compose init --help #196

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Added oci example in score-compose init --help #196

merged 2 commits into from
Oct 20, 2024

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

@7h3-3mp7y-m4n 7h3-3mp7y-m4n commented Oct 19, 2024 •
edited
Loading

Description

This PR add the oci example to init.go and also a updated output format. #178

What does this PR do?

By adding the oci example it help people to understand the new feat.
Screenshot 2024-10-20 at 1 00 47 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@7h3-3mp7y-m4n
Copy link
Contributor Author

I think this one will be much better
Screenshot 2024-10-20 at 1 58 25 AM

@7h3-3mp7y-m4n 7h3-3mp7y-m4n changed the title Added oct example Added oct example in score-compose Oct 19, 2024
@mathieu-benoit mathieu-benoit changed the title Added oct example in score-compose Added oci example in score-compose init --help Oct 20, 2024
mathieu-benoit
mathieu-benoit approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @7h3-3mp7y-m4n, clearer output, LGTM

@mathieu-benoit mathieu-benoit merged commit 2f3cf2c into score-spec:main Oct 20, 2024
4 checks passed
@mathieu-benoit mathieu-benoit mentioned this pull request Oct 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieu-benoit mathieu-benoit mathieu-benoit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7h3-3mp7y-m4n @mathieu-benoit