Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added oci example add the provisioner parameter in docs #126

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

What is the motivation?

Added oci example add the provisioner parameter in docs

Provide information on the motivation for why you have made this change.

What does this change do?

Added the missing documentation.
Provide a description of what this pull request does.

What is your testing strategy?

Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.
I read the Readme.md to check it locally
here are my changes
for score-k8s
Screenshot 2024-10-20 at 3 16 39 AM

for score-compose
Screenshot 2024-10-20 at 3 19 22 AM

Is this related to any issues?

YES
If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.
Issue

Have you read the Contributing Guidelines?

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having the same formatting/output than the actual --help command with the bullets points you did?
image

@7h3-3mp7y-m4n
Copy link
Contributor Author

What about having the same formatting/output than the actual --help command with the bullets points you did? image

Yes, We can do that :)

@mathieu-benoit
Copy link
Contributor

Bumping this one since we now have this new score-go release https://github.com/score-spec/score-go/releases/tag/v1.8.4 integrated in both score-compose and score-k8s. Thanks in advance!

@7h3-3mp7y-m4n
Copy link
Contributor Author

Okay, let me beautify it a little like bullet points?

@7h3-3mp7y-m4n
Copy link
Contributor Author

Screenshot 2024-11-03 at 9 13 53 PM

Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
@mathieu-benoit
Copy link
Contributor

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit mathieu-benoit merged commit 3e422e1 into score-spec:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants