-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto npm publish action #161
base: master
Are you sure you want to change the base?
Conversation
@sclausen Could you review this please? |
Yes I will. I have to read up on github actions and encrypted secrets first but am currently on vacation. |
I think it would be better, if the action just runs on pushing a tag, rather than on every commit in the master. |
@AlxZchk could you change it to run on tag? |
@sclausen if we can automate bumping of version via actions (like https://github.com/mikeal/merge-release) probably it could be better to execute it on any merge? |
@johnbizokk can you suggest some best practices to publish NPM packages? |
@nosovk You added |
We can store 0.0.0 as package version in repo, and store real version in npm during prepublish. Like go to npm, get current version, depending on commit message upgrade version, publish new version to NPM. |
8d4bd4a
to
c8e81b0
Compare
Added a github action to auto publish library on push to the master branch. You have to add NPM_TOKEN secret to make it work. The only issue is that tests are failing so I removed them from the chain.