Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save searches #895

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Save searches #895

wants to merge 5 commits into from

Conversation

hkethi002
Copy link
Contributor

@hkethi002 hkethi002 commented Aug 9, 2017

Fixes #881

Changes

  • New collection savesearches
    • permissions
    • search query
    • creator
    • label
  • SaveSearchHandler
    • Save new search, POST /savesearches
    • Replace saved search with a new one, POST /savesearches/{SearchId}
    • Get all saved searches user has access to, GET /savesearches
    • Get specific search by Id, GET /savesearches/{SearchId}
    • Delete a specific search, DELETE /savesearches/{SearchId}
    • Permission functions, /savesearches/{SearchId}/permissions

Examples Request

POST /savesearches

{
    "label" : "Example Search",
    "search": {
        "return_type" : "sessions"
    }
}

A replace would look identical except the request url would be POST /savesearch/{SaerchId}

The replace method can directly take the response body of GET /savesearches/{SearchId}

Review Checklist

  • Tests were added to cover all code changes
  • Documentation was added / updated
  • Code and tests follow standards in CONTRIBUTING.md

@codecov-io
Copy link

codecov-io commented Sep 20, 2017

Codecov Report

Merging #895 into master will decrease coverage by 0.01%.
The diff coverage is 90.42%.

@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
- Coverage   91.12%   91.11%   -0.02%     
==========================================
  Files          50       51       +1     
  Lines        6888     6981      +93     
==========================================
+ Hits         6277     6361      +84     
- Misses        611      620       +9

@hkethi002 hkethi002 force-pushed the save-search branch 2 times, most recently from ec506e5 to e2a94a3 Compare November 1, 2017 15:44
@hkethi002 hkethi002 force-pushed the save-search branch 3 times, most recently from b1e9fc1 to 22e36c8 Compare December 6, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants