Update .gitmodules to use https urls #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes good catch @dark64 thanks for this. I actually updated it on clearmatics/libsnark#37 but forgot to propagate here... |
|
@ValarDragon is there any plan to release a new version of libsnark at some point in the near future? If so, I think this PR should probably target |
|
we can also use git to change protocol to https using below command git config --global url."https://".insteadOf git:// |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in the Git protocol security on GitHub https://github.blog/2021-09-01-improving-git-protocol-security-github/ broke our build script that clones libsnark. I found that some submodules referenced in
.gitmodulesuse the unencrypted git protocol and some usehttps, which produces an errorThe unauthenticated git protocol on port 9418 is no longer supportedif the repository is cloned using thehttpsprotocol.