Add Scilpy version - part 1 #1100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2024 12:50
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 69.52% 69.71% +0.18%
==========================================
Files 448 448
Lines 24087 24138 +51
Branches 3295 3295
==========================================
+ Hits 16747 16827 +80
+ Misses 5945 5915 -30
- Partials 1395 1396 +1
|
EmmaRenauld
requested changes
Dec 18, 2024
| description=__doc__ + tractometry_description, | ||
| formatter_class=argparse.RawTextHelpFormatter) | ||
| p = argparse.ArgumentParser(description=__doc__, | ||
| formatter_class=argparse.RawTextHelpFormatter, |
There was a problem hiding this comment.
I think here you need to keep the + tractometry_description
karanphil
requested changes
Jan 21, 2025
| Formerly: scil_compute_asym_odf_metrics.py | ||
| ------------------------------------------------------------------------ | ||
|
|
There was a problem hiding this comment.
Empty line here. It should be removed to be as the others.
| @@ -11,6 +11,14 @@ | |||
| Please use a hdf5 (.h5) file containing decomposed connections | |||
|
|
|||
| Formerly: scil_compute_fixel_afd_from_hdf5.py | |||
| ---------------------------------------------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
Same here, remove the line.
| @@ -28,6 +28,14 @@ | |||
| and --g2. | |||
|
|
|||
| Formerly: scil_compare_connectivity.py | |||
| ---------------------------------------------------------------------------- | |||
| [1] Rubinov, Mikail, and Olaf Sporns. "Complex network measures of brain | |||
There was a problem hiding this comment.
Missing the "References:"
| @@ -33,6 +33,11 @@ | |||
|
|
|||
| Formerly: scil_compute_bundle_volume.py or | |||
| scil_evaluate_bundles_individual_measures.py | |||
| ------------------------------------------------------------------------------ | |||
| References: | |||
| ------------------------------------------------------------------------------- | ||
| References: | ||
| [1] Chamberland M, Raven EP, Genc S, Duffy K, Descoteaux M, Parker GD, Tax CMW, | ||
| Jones DK. Dimensionality reduction of diffusion MRI measures for improved |
There was a problem hiding this comment.
Add tabs to make it clearer (like other scripts).
| import numpy as np | ||
|
|
||
| from dipy.io.gradients import read_bvals_bvecs |
There was a problem hiding this comment.
Why did you move that? If I am not mistaken, it should be with the libraries like numpy.
karanphil
reviewed
Jan 21, 2025
| @@ -23,7 +23,25 @@ | |||
| given as the ratio of the L2-norm of odd SH coefficients on the L2-norm of all | |||
| SH coefficients. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove this line also, just one line between paragraphs.
karanphil
reviewed
Jan 21, 2025
|
|
||
| ----------------------------------------------------------------------------- | ||
| Reference: | ||
| [1] Raffelt, D., Tournier, JD., Rose, S., Ridgway, GR., Henderson, R., |
| @@ -11,6 +11,15 @@ | |||
| Please use a bundle file rather than a whole tractogram. | |||
|
|
|||
| Formerly: scil_compute_fixel_afd_from_bundles.py | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #760
Part 1 of adding the Scilpy version to the scripts