-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - Implement Cox with Efron estimate #159
Conversation
…into cox-estimator
Maybe you can add a small section at the end of the doc example with lifelines to show that we handle ties the same way lifelines does? no need for another speed benchmark, just showing that we have this functionality too |
Yes, I agree with the idea! |
The edited example and benchmark in this PR may interest @ogrisel too :) |
Haha the benchmark plot! 😅 |
BTW do you see a similar perf improvement for smooth penalties? |
@ogrisel we have added support for L2 regularization too (with scipy LBFGS and our Prox Newton methods). Also, here is the link to the complete benchmark and the repo to reproduce it. |
A follow-up of #157,
Handling tied data using Efron estimate can be obtained by slightly modifying the Cox datafit as follows
where$\mathbf{A}$ is a matrix chosen accordingly to account for the additional term in the Breslow $\log$ .$\mathbf{A} v$ or $\mathbf{A}^\top v$ is cheap and can be obtained in linear time.
Also, evaluating
Link to the maths behind