Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links #349

Merged
merged 1 commit into from
Aug 4, 2023
Merged

fix: links #349

merged 1 commit into from
Aug 4, 2023

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Jul 13, 2023

Trying to fix some of the links. Issues listed in #343 (comment) still present:

Signed-off-by: Henry Schreiner <[email protected]>
@eduardo-rodrigues
Copy link
Member

eduardo-rodrigues commented Jul 13, 2023

Thank you for this!

For https://scikit-hep.org/pylhe/, that's strange. It was probably me adding the link to the docs, hence it existed at the time. Let's see if @matthewfeickert recalls anything ... Else we replace with a link to the README as in some other places.

@eduardo-rodrigues
Copy link
Member

Closes #350.

@matthewfeickert
Copy link
Member

It was probably me adding the link to the docs, hence it existed at the time. Let's see if @matthewfeickert recalls anything ... Else we replace with a link to the README as in some other places.

Sorry somehow missed this. I don't have any other information beyond that this is yet another reminder for me to take a weekend and just finish scikit-hep/pylhe#30

@henryiii
Copy link
Member Author

henryiii commented Aug 3, 2023

We can merge then follow up.

@eduardo-rodrigues
Copy link
Member

We can merge then follow up.

Sounds good and very pragmatic to me.

@henryiii henryiii merged commit db42d5b into main Aug 4, 2023
@henryiii henryiii deleted the henryiii/fix/links branch August 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants