Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python 3.8 and test 3.13 #163

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Conversation

ariostas
Copy link
Collaborator

No description provided.

@ariostas
Copy link
Collaborator Author

@eduardo-rodrigues when you get a chance could you generate a codecov token and add it as a secret named CODECOV_TOKEN? I noticed that it's not working because since v4 it requires a token. Thanks!

@eduardo-rodrigues
Copy link
Member

Hi @ariostas, well spotted and thanks for the ping. Apologies I have been slow, at a workshop. I've added the secret just now.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (9ed1610) to head (2637754).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   69.78%   72.38%   +2.60%     
==========================================
  Files           3        3              
  Lines         139      134       -5     
==========================================
  Hits           97       97              
+ Misses         42       37       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ariostas ariostas requested a review from jpivarski November 18, 2024 16:11
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Feel free to merge!

.github/workflows/ci.yml Show resolved Hide resolved
@ariostas
Copy link
Collaborator Author

@jpivarski could you update the required checks to be just this new pass job? I did that so they don't have to be updated every time a Python version is added or dropped (like how it is now done in Uproot).

(I'm not sure if this PR needs to be merged before you can do that)

@jpivarski
Copy link
Member

It doesn't: I'll do that right now.

@jpivarski
Copy link
Member

image

The two things that are strictly required now are

  • pre-commit.ci - pr
  • pass

I could also add the codecov tests to the required set, since they're not in the dependency graph that ends in "pass". However, we've never required them before.

@ariostas
Copy link
Collaborator Author

Thanks, Jim!

@ariostas ariostas merged commit 3da59d0 into main Nov 18, 2024
7 checks passed
@ariostas ariostas deleted the ariostas/drop_python_38 branch November 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants