-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop python 3.8 and test 3.13 #163
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@eduardo-rodrigues when you get a chance could you generate a codecov token and add it as a secret named CODECOV_TOKEN? I noticed that it's not working because since v4 it requires a token. Thanks! |
Hi @ariostas, well spotted and thanks for the ping. Apologies I have been slow, at a workshop. I've added the secret just now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 69.78% 72.38% +2.60%
==========================================
Files 3 3
Lines 139 134 -5
==========================================
Hits 97 97
+ Misses 42 37 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Feel free to merge!
@jpivarski could you update the required checks to be just this new (I'm not sure if this PR needs to be merged before you can do that) |
It doesn't: I'll do that right now. |
Thanks, Jim! |
No description provided.