Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a 'get started' example to the README #130

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

eduardo-rodrigues
Copy link
Member

Relates to task #30 on package documentation.

@eduardo-rodrigues eduardo-rodrigues changed the title [doc] README - add a get started docs: README - add a get started Jun 8, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #130 (23a97f8) into master (555f5d9) will not change coverage.
The diff coverage is n/a.

❗ Current head 23a97f8 differs from pull request most recent head de3199c. Consider uploading reports for the commit de3199c to get more accurate results

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files           2        2           
  Lines         234      234           
  Branches       59       59           
=======================================
  Hits          147      147           
  Misses         76       76           
  Partials       11       11           
Flag Coverage Δ
unittests-3.10 61.53% <ø> (ø)
unittests-3.6 60.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555f5d9...de3199c. Read the comment docs.

@eduardo-rodrigues
Copy link
Member Author

This seems like a no-brainer in terms of basic documentation. Can we merge it asap :)?

@eduardo-rodrigues
Copy link
Member Author

With no further news I will merge later today since really an enhancement to documentation.

@matthewfeickert matthewfeickert changed the title docs: README - add a get started docs: Add a 'get started' example to the README Jun 20, 2022
@matthewfeickert matthewfeickert added the docs Documentation related label Jun 20, 2022
@matthewfeickert
Copy link
Member

(This is failing for known reasons that will get removed in PR #131 so I'm merging anyway)

@matthewfeickert matthewfeickert merged commit 8beb29c into master Jun 20, 2022
@matthewfeickert matthewfeickert deleted the eduardo-readme-1 branch June 20, 2022 02:52
eduardo-rodrigues added a commit to jhgoh/pylhe that referenced this pull request Aug 25, 2022
* Add example to README that shows how to open an LHE file and interact with
the events.
eduardo-rodrigues added a commit that referenced this pull request Aug 29, 2022
* take particles up to the eventinfo.nparticles. otherwise put into the optinal field

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* synchronize with the master branch

* Add test

* Please linting checks

* ci: Add semantic PR check GHA workflow (#123)

* As https://github.com/zeke/semantic-pull-requests is no longer maintained
and is down, use the suggested alternative of
https://github.com/amannn/action-semantic-pull-request to check that PR titles
follow the Conventional Commits spec.

* feat: Add IPython visualisation and switch to graphviz (#118)

* Add graphviz>=0.12.0 as a core dependency.
* Add graphviz.Digrap graph object as .graph property to LHEFile.
   - Add support for IPython visualization.
* Add test for LHEEvent_graph.

* refactor: Use absolute imports over explicit relative imports (#124)

* Change all explicit relative imports to absolute imports.
   - Provides clearer more explicit imports for new developers.
* Add absolufy-imports to pre-commit hooks

* feat: Use tbump over bump2version (#125)

* Add tbump to 'develop' extra and remove bump2version.
* Add tbump.toml to configure tbump.
   - Allow for valid versions to follow SemVer and also support release
candidates: <major>.<minor>.<patch>rc<candidate>
* Remove .bumpversion.cfg.

* Bump version: 0.2.1 → 0.3.0

* docs: Update dev team affiliations (#126)

* Lukas Heinrich is a professor at Technical University of Munich as of March 2022.
* Matthew Feickert is a postdoc at University of Wisconsin-Madison as of June 2022.

* docs: Add Eduardo Rodrigues to dev team (#127)

* Add Eduardo Rodrigues to development team listing.
   - Update Zenodo citation metadata, recommended citation, and setup.cfg.

* chore: [pre-commit.ci] pre-commit autoupdate (#129)

* Update pre-commit hooks:
   - github.com/asottile/pyupgrade: v2.32.0 → v2.32.1

* docs: Add a 'get started' example to the README (#130)

* Add example to README that shows how to open an LHE file and interact with
the events.

* chore: [pre-commit.ci] pre-commit autoupdate (#133)

* Update pre-commit hooks:
   - github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0
   - github.com/asottile/pyupgrade: v2.31.1 → v2.34.0
   - github.com/psf/black: 22.3.0 → 22.6.0

* take particles up to the eventinfo.nparticles. otherwise put into the optinal field

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* synchronize with the master branch

* Cover lines added/changed

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: eduardo-rodrigues <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
APN-Pucky added a commit to APN-Pucky/pylhe that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants