feat: Use Python 3.12+ tarfile data extraction filter #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In Python 3.12 extraction filters are added and in will become default in Python 3.14. To start using them for when Python 3.12 support is added, and to guard against a Python 3.14 DeprecatinoWarning, use the data extraction filter for extracting tarfiles in pyhf.contrib.utils.download. - c.f. https://docs.python.org/3.12/library/tarfile.html#extraction-filters
matthewfeickert
added
feat/enhancement
matthewfeickert
commented
Mar 13, 2024
Comment on lines
+94
to
+97
| # TODO: Simplify after pyhf is Python 3.12+ only | ||
| # c.f. https://docs.python.org/3.12/library/tarfile.html#extraction-filters | ||
| if hasattr(tarfile, "data_filter"): | ||
| archive.extractall(output_directory, filter="data") |
There was a problem hiding this comment.
This won't ever get run in the current tests and so Codecov is going to complain, but is passes on the testing Python 3.12 branch that I have and so will get covered in the future.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
- Coverage 98.28% 98.23% -0.05%
==========================================
Files 69 69
Lines 4539 4541 +2
Branches 803 804 +1
==========================================
Hits 4461 4461
- Misses 45 46 +1
- Partials 33 34 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
|
@meeseeksdev backport to release/v0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pyhf
that referenced
this pull request
May 30, 2024
matthewfeickert
removed
the
need-to-backport
matthewfeickert
added a commit
that referenced
this pull request
May 30, 2024
* Backport PR #2455 * In Python 3.12 extraction filters are added and will become default in Python 3.14. To start using them for when Python 3.12 support is added, and to guard against a Python 3.14 DeprecationWarning, use the data extraction filter for extracting tarfiles in pyhf.contrib.utils.download. - c.f. https://docs.python.org/3.12/library/tarfile.html#extraction-filters Co-authored-by: Matthew Feickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2454
In Python 3.12 extraction filters are added and will become default in Python 3.14. To start using them for when Python 3.12 support is added, and to guard against a Python 3.14 DeprecationWarning, use the data extraction filter for extracting tarfiles in
pyhf.contrib.utils.download.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: