-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New schema for HS3 Support #2397
base: feat/updateJSONSchemaDraft
Are you sure you want to change the base?
Conversation
"parameter": { | ||
"type": "object", | ||
"properties": { | ||
"name": { "type": "string" }, | ||
"auxdata": { "type": "array", "items": {"type": "number"}, "minItems": 1 }, | ||
"factors": { "type": "array", "items": {"type": "number"}, "minItems": 1 }, | ||
"sigmas": { "type": "array", "items": {"type": "number"}, "minItems": 1} | ||
}, | ||
"required": ["name"], | ||
"additionalProperties": false | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the object that goes into parameter_points
in the current HS3 draft? I don't quite follow how to map this to the document. I started looking at this as I as wondering if the format would allow to conveniently distinguish between initial parameter values for the purpose of minimization starting point and default values for the purpose of dataset generation.
Runtime validations:
staterror
is only defined once per samplestaterror
is defined, that the sample has definederrors
contents
anderrors
have the same shape iferrors
is definedlikelihoods.distributions
has same shape aslikelihoods.datasets
measurements.likelihood
points to a validlikelihood
measurements.domains
points to a validdomain
measurements.inits
points to a validinit
data
optional (in cases where it wasnull
)Accepted Defaults:
errors
To Dos:
inits
anddomains
)measurements
key, and fordatasets
keyaxis
in HS3 (binned vs unbinned)measurement.poi
vsmeasurement.parameters_of_interest
modifier.parameters
tomodifier.parameter
(forpyhf
) [since we don't have per-parameter naming]version
intometadata.version
References:
Pull Request Description
Please first read CONTRIBUTING.md.
Please describe the purpose of this pull request in some detail and what the specific feature being added will do. Reference and link to any relevant issues or pull requests (such as the issue in which this feature was first suggested).
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: