-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove os-dependent pieces of schema validation #2357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2357 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 69 69
Lines 4538 4539 +1
Branches 803 803
=======================================
+ Hits 4460 4461 +1
Misses 45 45
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kratsg. I just did some typo fixes and also linked to python/cpython#65238.
@kratsg I see that you want to keep this in draft mode for the time being. I am okay to merge this whenever you're ready assuming no additional large changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking this against both Windows 10 and Windows 11, @kratsg. 👍
* Backport PR #2357 * Use pathlib to build the stem for the schema to use (version + type of schema). - c.f. python/cpython#65238 Co-authored-by: Giordon Stark <[email protected]>
Pull Request Description
Resolves #2353. To allow
pyhf
to work a little bit better, at least on schemas on Windows, need to rely either onpathlib
more fully oros.sep
in order to build the paths correctly.add an additional example that is os-independentChecklist Before Requesting Reviewer
Before Merging
For the PR Assignees: