Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Remove disallow of TensorFlow v2.14.0 #2344

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 3, 2023

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* With the release of tensorflow-probability v0.22.0, tensorflow v2.14.0
  can be used and is required for tensorflow-probability v0.22.0+.
   - c.f. https://github.com/tensorflow/probability/releases/tag/v0.22.0
* Reverts PR https://github.com/scikit-hep/pyhf/pull/2342

* With the release of tensorflow-probability v0.22.0, tensorflow v2.14.0
  can be used and is required for tensorflow-probability v0.22.0+.
   - c.f. https://github.com/tensorflow/probability/releases/tag/v0.22.0
* Revert PR 2342
@matthewfeickert matthewfeickert added the revert Reverts a previous commit label Oct 3, 2023
@matthewfeickert matthewfeickert self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f280cb2) 98.28% compared to head (1645a13) 98.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2344   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4538     4538           
  Branches      803      803           
=======================================
  Hits         4460     4460           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 60.99% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.31% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit 976eec1 into main Oct 3, 2023
19 checks passed
@matthewfeickert matthewfeickert deleted the revert/open-up-tf-for-tfp branch October 3, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert Reverts a previous commit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant