Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update release checklist notes for Conda-forge and LCG views #2021

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 22, 2022

Description

  • Note that Conda-forge has a conda-grayskull bot that can help users update build requirements.
  • Add that it is the dev team's responsibility to ask the CERN LCG view team to put the new release of pyhf in the next LCG release.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Note that Conda-forge has a conda-grayskull bot that can help users update
  build requirements.
   - c.f. https://twitter.com/mdtrevisani/status/1487894867799859201
* Add that it is the dev team's responsibility to ask the CERN LCG view team
  to put the new release of pyhf in the next LCG release.

* Note that Conda-forge has a conda-grayskull bot that can help users
  update build requirements.
   - c.f. https://twitter.com/mdtrevisani/status/1487894867799859201
* Add that it is the dev team's responsibility to ask the CERN LCG view
  team to put the new release of pyhf in the next LCG release.
@matthewfeickert matthewfeickert added the docs Documentation related label Sep 22, 2022
@matthewfeickert matthewfeickert self-assigned this Sep 22, 2022
@matthewfeickert
Copy link
Member Author

This is migrated from PR #1705. c.f. https://github.com/scikit-hep/pyhf/pull/1705/files#r796375487

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 98.29% // Head: 98.29% // No change to project coverage 👍

Coverage data is based on head (31c5a66) compared to base (a3ddb5f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2021   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          69       69           
  Lines        4529     4529           
  Branches      738      738           
=======================================
  Hits         4452     4452           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 27.51% <ø> (ø)
doctest 61.13% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.7 96.28% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert merged commit e38c502 into main Sep 23, 2022
@matthewfeickert matthewfeickert deleted the docs/update-release-checklist branch September 23, 2022 00:19
@matthewfeickert matthewfeickert mentioned this pull request Sep 23, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant