Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Experimental implementation of custom modifiers #1991

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

split names with with _

c1a5f08
Select commit
Loading
Failed to load commit list.
Draft

feat: Experimental implementation of custom modifiers #1991

split names with with _
c1a5f08
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 10, 2023 in 0s

97.94% (-0.34%) compared to ecbe778

View this Pull Request on Codecov

97.94% (-0.34%) compared to ecbe778

Details

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ecbe778) 98.28% compared to head (c1a5f08) 97.94%.

❗ Current head c1a5f08 differs from pull request most recent head d9ccf67. Consider uploading reports for the commit d9ccf67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
- Coverage   98.28%   97.94%   -0.34%     
==========================================
  Files          69       70       +1     
  Lines        4538     4629      +91     
  Branches      803      814      +11     
==========================================
+ Hits         4460     4534      +74     
- Misses         45       55      +10     
- Partials       33       40       +7     
Files Coverage Δ
src/pyhf/experimental/modifiers.py 87.91% <87.91%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.