-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle absolute paths in XML config files (xml2json / readxml) #1909
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
- Coverage 98.22% 98.19% -0.04%
==========================================
Files 68 68
Lines 4334 4365 +31
Branches 730 734 +4
==========================================
+ Hits 4257 4286 +29
- Misses 45 46 +1
- Partials 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
74e543e
to
75cc278
Compare
32fb70f
to
0c29f3e
Compare
0c29f3e
to
2c3c482
Compare
@matthewfeickert this is ready, but codecov is broken for this one (some glitch on their side of things) probably related to my rebasing to clean things up. |
Relevant RTD build: https://pyhf--1909.org.readthedocs.build/en/1909/_generated/pyhf.readxml.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking super good.
I have a few questions and suggestions, but nothing major, just things that we could decide if we want to fixup now as they're getting added for the first time.
Co-authored-by: Matthew Feickert <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks @kratsg!
* Update lower bound of the supported click versions to v8.0.0 as it is required to support behavior in PR #1909. * Update tests/constraints.txt to use click==8.0.0.
* Update lower bound of the supported click versions to v8.0.0 as it is required to support behavior in PR #1909. * Update tests/constraints.txt to use click==8.0.0.
* Update lower bound of the supported click versions to v8.0.0 as it is required to support behavior in PR #1909 due to click v7.x not setting the type correctly for path type arguments. - c.f. #1957 (comment) * Update tests/constraints.txt to use click==8.0.0.
Pull Request Description
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: