Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDG particle data table 2019 update #137

Merged
merged 15 commits into from
Jun 10, 2019
Merged

PDG particle data table 2019 update #137

merged 15 commits into from
Jun 10, 2019

Conversation

eduardo-rodrigues
Copy link
Member

The 2019 update is out!

I need to update our CSV files with this and make 2019 the default …

This should go out in a 0.5.0 release, which should at least include the update described in #118.

@eduardo-rodrigues eduardo-rodrigues marked this pull request as ready for review June 5, 2019 09:27
@eduardo-rodrigues
Copy link
Member Author

Hi @henryiii, this PR is now ready for review. All ready apart from one little thing: I put in a temporary fix in particle/particle/convert.py to generate the 2019 CSV file with updates, as otherwise Pandas would give me an error. I suspect that's because, as it is, one is effectively adding twice the file with PDG ID - LaTeX name matches. Maybe you have your preferred way to make the user LaTeX file optional when passed to the convert(...) function (my temporary fix is just a hack). Thanks.

@eduardo-rodrigues eduardo-rodrigues mentioned this pull request Jun 6, 2019
Closed
@eduardo-rodrigues
Copy link
Member Author

OK, @henryiii, I've now fixed particle.particle.convert.py making the extra LaTeX file optional.

This is ready to go in as far as I'm concerned.

@eduardo-rodrigues eduardo-rodrigues mentioned this pull request Jun 7, 2019
Closed
henryiii
henryiii approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good save for the one suggestion.

@eduardo-rodrigues eduardo-rodrigues merged commit 8740e8b into master Jun 10, 2019
@eduardo-rodrigues eduardo-rodrigues deleted the eduardo-pdg-2019 branch June 10, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
data files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardo-rodrigues @henryiii