Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_bytes #52

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix read_bytes #52

merged 1 commit into from
Mar 5, 2024

Conversation

chrisburr
Copy link
Member

No description provided.

@chrisburr chrisburr mentioned this pull request Mar 3, 2024
Merged
nsmith-
nsmith- approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the option of not specifying start and end to _cat_file. Is this a feature of other fsspec filesystems that we didn't support previously? In any case, it's a good addition.

@chrisburr
Copy link
Member Author

Yes. After running into this bug, I wrote test_read_bytes_fsspec against a local file to make sure I understood the expected behavior and then fixed fsspec-xrootd.

@chrisburr
Copy link
Member Author

See https://github.com/fsspec/filesystem_spec/blob/8a542c8c555614ab91fe07ce27a2d3dd3fd6700f/fsspec/spec.py#L1484-L1486

@nsmith- nsmith- merged commit 72c5b28 into scikit-hep:main Mar 5, 2024
7 checks passed
@chrisburr chrisburr deleted the read_bytes branch March 5, 2024 16:41
@ikrommyd ikrommyd mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmith- nsmith- nsmith- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisburr @nsmith-