feat: switch permit_dask to True by default #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nsmith- I've had to mangle some parts of the nanoevents schema system to get this all to fit right. I think it's worth a look from you to determine a way to make the non-user facing parts of the interface decent again. |
for more information, see https://pre-commit.ci
|
@nsmith- can you give this a look and lodge your complaints? May not get fixed in this PR but we can plan it for the future. |
nsmith-
reviewed
Nov 9, 2023
| @@ -10,14 +10,14 @@ | |||
| fname = "tests/samples/nano_dy.root" | |||
| eagerevents = NanoEventsFactory.from_root( | |||
| {os.path.abspath(fname): "Events"}, | |||
| schemaclass=NanoAODSchema.v6, | |||
| schemaclass=NanoAODSchema, | |||
There was a problem hiding this comment.
Does the .v6 specialization still work but is just not needed?
There was a problem hiding this comment.
Right now the .vX specializations are a little broken in their original implementation. The functional sub-classing thing you were doing doesn't quite fit into the daskiness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes dask-based nanoevents the default.
Currently there are some unrelated blockers for from (dask-)awkward related to numpy reducers.