-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added hasattr check to NanoAODEvents __repr__ #909
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
881ec08
Added hasattr check to NanoAODEvents __repr__
pviscone c0bcf07
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c5dec42
Added Exception and warning if event_ids are missing
pviscone 09e6231
fix: wrong branches dict variable
pviscone 711b5e3
Added comment on event IDs
pviscone e25a6bc
Reformatted exception message
pviscone ada3e13
Improved code clarity of the check of missing event_ids
pviscone 90ac5eb
Improved Exception message
pviscone d4237c0
NanoAODEvents repr warn about the missing event_ids
pviscone 86c498d
decreased verbosity of the NanoAODEvents repr
pviscone 38f5fe3
Added missing luminosityBlock test sample
pviscone c5f3c25
Added error/warning test on missing luminosityBlock sample
pviscone 33411f8
Merge branch 'master' into master
lgray 0810dd8
specify tree
lgray c99aefe
use RuntimeError
lgray 1acd191
pytest.raises for RuntimeError
lgray 9c8a810
use appropriate pytest interface
lgray 8df1111
escape the regexes
lgray 8b93311
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f0e1a3e
regular expressions are only good for so many things
lgray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a safer way to turn the error_missing_events_ids flag to False?
In this way, I think that it will disable it globally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the intended pattern, it's fine!