Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin dask < 2024.12.0 for taskvine tests #1232

Merged
merged 3 commits into from
Dec 17, 2024
Merged

ci: pin dask < 2024.12.0 for taskvine tests #1232

merged 3 commits into from
Dec 17, 2024

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented Dec 16, 2024

Checking to see if we pass tests with this version of dask-awkward or if there are residual problems.

@lgray
Copy link
Collaborator Author

lgray commented Dec 16, 2024

@btovar It looks like there may be some growing pains with the most recent dask and daskvine!

@btovar
Copy link
Contributor

btovar commented Dec 17, 2024

Mmm, can confirm it works with ndcctools 7.14.0 and dask, dask-awkward < 2024.12.0, so you are probably right.

@btovar
Copy link
Contributor

btovar commented Dec 17, 2024

That new dask._task_spec.Task is confusing the dag processing. Seems to be equivalent to a tuple call like (f, arg)?

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

Yeah the old tuples are now handled using Tasks and TaskRefs.

@lgray
Copy link
Collaborator Author

lgray commented Dec 17, 2024

Here's the PR where they introduced it: dask/dask#11568

@btovar
Copy link
Contributor

btovar commented Dec 17, 2024

Got it, thanks! Need to think about this one since we really relied on the graph being tuple-based for processing, and we have code that manually generates graphs with tuples, so we would like to preserve both.

@lgray lgray changed the title build: require dask-awkward 2024.12.1 ci: pin dask < 2024.12.0 for taskvine tests Dec 17, 2024
@lgray lgray merged commit af4dff0 into master Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants