Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit parameter variations in rankings to stay within parameter bounds #490

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Oct 22, 2024

As identified by @malin-horstmann, we can run into scenarios where the ranking will attempt to vary parameters beyond their bounds. This can happen with parameters that have asymmetric uncertainties when only a symmetric estimate was done from the Hessian (for shapesys in particular this is likely to happen).

This PR limits the variations to stick within bounds. Things to think about before finishing this:

  • raise a warning? (seems useful, but hard to miss in verbose ranking output)
  • allow for a way to propagate MINOS uncertainties through instead?
  • visually flag such cases in the plot?

The CI fail is currently expected (bounds kwarg changes).

* force parameter variations in ranking to stay within parameter bounds

@alexander-held alexander-held marked this pull request as draft October 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant