feat: limit parameter variations in rankings to stay within parameter bounds #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @malin-horstmann, we can run into scenarios where the ranking will attempt to vary parameters beyond their bounds. This can happen with parameters that have asymmetric uncertainties when only a symmetric estimate was done from the Hessian (for
shapesys
in particular this is likely to happen).This PR limits the variations to stick within bounds. Things to think about before finishing this:
The CI fail is currently expected (bounds kwarg changes).