test: update likelihood scan reference visualization for latest matplotlib #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matplotlib
3.9 release caused a change in the legend positioning of the likelihood scan visualization used as reference. This is presumably due to https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.9.0.html#loc-best-for-legend-now-considers-text-and-polycollections. Updating the reference here to be up to date with the latest legend positioning.The Python 3.8 test uses an older version of
matplotlib
with different legend positioning. Since support for that version will presumably be dropped sooner or later anyway, it seems reasonable to accept a failing reference figure check. The old legend positioning is still perfectly fine, so this is flagged asxfail
for that specific version.