Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use 2x faster black mirror #426

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

henryiii
Copy link
Member

@alexander-held
Copy link
Member

Thanks @henryiii! Looks like the latest typeguard release requires a newer typing-extensions version that clashes with the requirements made by tensorflow (which caps the typing-extensions version). This conflict has unfortunately happened before, I'll have a look to fix this externally and can then rebase this for CI to pass.

@henryiii
Copy link
Member Author

I'd bring it up with the TF people, and maybe recommend they remove the cap on this. Very high chance it's actually fine (typing-extensions doesn't break stuff much, and is mostly useful at type-check time, not runtime), and they've loosed some other caps before.

@alexander-held
Copy link
Member

alexander-held commented Aug 11, 2023

Looks like this will be fixed in the next TF release: tensorflow/tensorflow#60687 (comment).

edit: target for that is Sep 6 according to https://discuss.tensorflow.org/t/upcoming-tensorflow-2-14-branch-cut-release-dates/18220

Will restrict typeguard temporarily to have working CI and then revert that after the next TF release. See #428.

* switch to faster black mirror for pre-commit

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0490607) 100.00% compared to head (47da8b7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #426   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2072      2072           
  Branches       338       338           
=========================================
  Hits          2072      2072           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit a0638e1 into master Aug 17, 2023
7 checks passed
@alexander-held alexander-held deleted the all-repos_autofix_all-repos-sed branch August 17, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants