feat: allow custom top-level properties in configuration schema (#488)

* allow custom top-level properties in configuration schema
scikit-hep · Oct 1, 2024 · 8f78894 · 8f78894
1 parent d410d35
commit 8f78894
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/cabinetry/schemas/config.json b/src/cabinetry/schemas/config.json
@@ -422,5 +422,5 @@
             "additionalProperties": false
         }
     },
-    "additionalProperties": false
+    "additionalProperties": true
 }
diff --git a/tests/test_configuration.py b/tests/test_configuration.py
@@ -23,12 +23,13 @@ def test_validate():
     }
     assert configuration.validate(config_valid)
 
-    # not exactly one data sample
+    # not exactly one data sample, custom additional top-level properties
     config_multiple_data_samples = {
         "General": {"Measurement": "", "HistogramFolder": "", "InputPath": ""},
         "Regions": [{"Name": "", "Filter": "", "Variable": "", "Binning": [0, 1]}],
         "Samples": [{"Name": "", "Tree": ""}],
         "NormFactors": [{"Name": ""}],
+        "ABC": [],
     }
     with pytest.raises(
         NotImplementedError, match="can only handle cases with exactly one data sample"