Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram Comparison (Public Facing) #778

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e929fe2
Update BoostHistogramHandsOn.ipynb
gohil-jay Jun 23, 2022
4700409
Merge branch 'scikit-hep:develop' into develop
gohil-jay Jun 27, 2022
c26aa03
Merge branch 'scikit-hep:develop' into develop
gohil-jay Jun 27, 2022
7d8252a
Updated all numpy.testing asserts to pytest.approx
gohil-jay Jun 27, 2022
a063d37
Updated all numpy.testing asserts to pytest.approx
gohil-jay Jun 27, 2022
65f0a1c
Updated all numpy.testing asserts to pytest.approx
gohil-jay Jun 27, 2022
b877ee5
style: pre-commit fixes
pre-commit-ci[bot] Jun 29, 2022
190e6ce
Wrapping this assert to remove test failing
gohil-jay Jun 30, 2022
b69b165
Merge branch 'scikit-hep:develop' into issue157
gohil-jay Jul 1, 2022
b6b0003
Added histograms comparison function
gohil-jay Jul 1, 2022
ebe0cff
Added 'compare' operation
gohil-jay Jul 1, 2022
772104c
style: pre-commit fixes
pre-commit-ci[bot] Jul 1, 2022
220c1ca
Tweaked the comparison function
gohil-jay Jul 1, 2022
246cc2f
style: pre-commit fixes
pre-commit-ci[bot] Jul 1, 2022
8a61023
Added type annotation
gohil-jay Jul 1, 2022
c2994e2
Updated function return from bool to colorized str
gohil-jay Jul 1, 2022
d1f5797
Updated annotation type and syntax
gohil-jay Jul 1, 2022
fb5af1e
style: pre-commit fixes
pre-commit-ci[bot] Jul 1, 2022
bae1ecd
Updated function with linear checks & f"str return
gohil-jay Jul 1, 2022
e6a3a2a
style: pre-commit fixes
pre-commit-ci[bot] Jul 1, 2022
8a36fe8
Fixed a typo
gohil-jay Jul 1, 2022
e0c2f5a
Removed colorized return text
gohil-jay Jul 1, 2022
b7096bd
Solved few pylint issues
gohil-jay Jul 1, 2022
fd2bcec
style: pre-commit fixes
pre-commit-ci[bot] Jul 1, 2022
69ab6dc
Redefined storage check & removed variance check
gohil-jay Jul 3, 2022
8df3ff6
Added histogram storage type operation
gohil-jay Jul 3, 2022
e9c1bd8
Tiny changes for pylint
gohil-jay Jul 3, 2022
9e79f51
Merge branch 'scikit-hep:develop' into issue157-2
gohil-jay Jul 14, 2022
9f5ebb9
Updated comparison function and mapped np.allclose
gohil-jay Jul 14, 2022
ceef764
Operation rename (compare -> allclose)
gohil-jay Jul 14, 2022
c132c1c
style: pre-commit fixes
pre-commit-ci[bot] Aug 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added type annotation
  • Loading branch information
gohil-jay authored Jul 1, 2022
commit 8a6102385b21f09ffdc96a25c79ff81b0217622b
2 changes: 1 addition & 1 deletion src/boost_histogram/_internal/hist.py
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ def ndim(self) -> int:
"""
return self._hist.rank()

def compare(self, hist2):
def compare(self, hist2) -> bool:
if np.allclose(self.view().shape, hist2.view().shape):
if np.allclose(self.view(), hist2.view()):
if np.allclose(self.variances(), hist2.variances()):
Expand Down