Skip to content

Commit

Permalink
☑️ Remove ChangeSet#prepopulate! test
Browse files Browse the repository at this point in the history
This test is fragile in that it does not account for the fact that we
can specify a :prepopulate option for a property.

When you specify the `:prepopulate` option (as in
`Hyrax::Form::PcdmCollection`) and use this shared spec, then the now
deleted spec fails with no recourse.

Related to:

- samvera/hyrax#6702
- samvera/hyrax#6703
  • Loading branch information
jeremyf committed Feb 19, 2024
1 parent 0007796 commit e9313b1
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions lib/valkyrie/specs/shared_specs/change_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@
end
end

describe "#prepopulate!" do
it "doesn't make it look changed" do
expect(change_set).not_to be_changed
change_set.prepopulate!
expect(change_set).not_to be_changed
end
end

describe "#required?" do
it "returns a boolean" do
expect(change_set.required?(change_set.fields.keys.first)).to be_in [true, false]
Expand Down

0 comments on commit e9313b1

Please sign in to comment.