Merge various smaller cleanups #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was added in 3b33514 but isn't required anymore (was probably only relevant for the initial development - we don't use that local test DB anymore and this depends on the local test setup so it should be set by the user/developer). Signed-off-by: Michael Weiss <[email protected]>
These are the last case-related "inconsistencies" that I found. Signed-off-by: Michael Weiss <[email protected]>
I added this exception in 697cbdb to make CI happy/green but we can now remove it again since the last update of the `indicatif` crate in 5a64ec8. Signed-off-by: Michael Weiss <[email protected]>
This is already done for `DEPENDENCY_PARSING_RE` but was missing for `VERSION_REGEX` (to parse `PackageVersion` into `semver::Version`). It's an optional performance optimization since re-compiling regexes should be avoided [0] and, depending on the code path, we might try to convert many `PackageVersion`s. [0]: https://docs.rs/regex/1.11.1/regex/index.html#avoid-re-compiling-regexes-especially-in-a-loop Signed-off-by: Michael Weiss <[email protected]>
This used to be required in the past for the `result-inspect` crate (s. 0b757ac) but the `Result::inspect()` API was stabilized in Rust version 1.76.0 [0] and we could drop that crate in 786404d. [0]: https://doc.rust-lang.org/stable/std/result/enum.Result.html#method.inspect Signed-off-by: Michael Weiss <[email protected]>
This was added in a54efe7 but currently isn't required anymore so let's drop it again. Signed-off-by: Michael Weiss <[email protected]>
I've added this in 0451b6d but the "Added in [Rust version]" information on the website [0] was wrong [1] (I was already suspicious as our Rust beta CI check only recently hit this but didn't bother to look into it until I got an unknown lint warning locally). [0]: https://rust-lang.github.io/rust-clippy/master/index.html#literal_string_with_formatting_args [1]: rust-lang/rust-clippy@db4aac6 Signed-off-by: Michael Weiss <[email protected]>
christophprokop
approved these changes
Jan 16, 2025
Merged
via the queue into
science-computing:master
with commit Jan 16, 2025
8d4d68f
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a bundling of some independent cleanups (21ccbc1 is more of an optional improvement). Details are in the individual commit messages.