Separar a extração de dados da tag <contrib-group> nas seções <article-meta> e <sub-article> #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,9 +22,16 @@ def collab(self): | |||
| return None | |||
|
|
|||
| @property | |||
| def contribs(self): | |||
| def contribs_in_article_meta(self): | |||
There was a problem hiding this comment.
@samuelveigarangel mantenha o @Property contribs, senão isso quebrará vários códigos.
Apenas crie o que você sentiu falta
| def contribs_in_sub_article(self): | ||
| return self.contribs(xpath_contrib=self.node.xpath(".//sub-article//contrib")) | ||
|
|
||
| def contribs(self, xpath_contrib): |
There was a problem hiding this comment.
@samuelveigarangel use outro nome para o método, mantenha o contribs original como property
samuelveigarangel
changed the title
|
|
||
| @property | ||
| def contribs_in_sub_article(self): | ||
| return self._extract_contribs(".//sub-article//contrib") |
There was a problem hiding this comment.
@samuelveigarangel o problema aqui é que você não está distinguindo de que sub-article é cada contrib. Altere de forma que seja possível selecionar contrib por sub-article.
robertatakenaka
requested changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que esse PR faz?
Separar a extração de dados da tag nas seções e
Onde a revisão poderia começar?
pelos commits
Como este poderia ser testado manualmente?
Algum cenário de contexto que queira dar?
N/A
Screenshots
Quais são tickets relevantes?
#739
Referências
N/A