-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: related article validation #698
Open
Rossi-Luciano
wants to merge
37
commits into
scieloorg:master
Choose a base branch
from
Rossi-Luciano:feat_realated_article_validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
71628cf
Adapta a classe de validação ao novo modelo
Rossi-Luciano 8cd2d4e
Adapta os testes
Rossi-Luciano 4f19b32
Adiciona validação para os atributos de 'related-article'
Rossi-Luciano e1c0ad1
Adiciona validação para evento em 'history'
Rossi-Luciano 641094a
Adiciona testes
Rossi-Luciano 7beefdc
Remove 'related_articles_matches_history_date_validation'
Rossi-Luciano 8e9232f
Adapta os testes
Rossi-Luciano fdc7fb0
Refatora e complementa validação de 'errata'
Rossi-Luciano e35d721
Adapta e adiciona testes
Rossi-Luciano 5cb9511
Remove 'validation' de 'title'
Rossi-Luciano 96a3999
Adapta os testes
Rossi-Luciano d3facd9
Refatora validação de 'errata'
Rossi-Luciano 530ad59
Adapta os testes
Rossi-Luciano 80664ef
Adiciona argumento "related_article_type"
Rossi-Luciano 078c2b8
Adiciona teste
Rossi-Luciano 3c9f8ef
Remove o módulo de validação de 'preprint'
Rossi-Luciano a1fc865
Remove o módulo de validação de 'errata'
Rossi-Luciano 35158fc
Corrige a extensão dos arquivos de listas controladas
Rossi-Luciano 2af892d
Adiciona 'related_article.json'
Rossi-Luciano 14f341f
Adiciona 'related_article_type_date_type.json'
Rossi-Luciano 619c161
Renomeia classe
Rossi-Luciano acfb059
Adiciona 'remove_namespaces()'
Rossi-Luciano 6f6b968
Aplica formatação
Rossi-Luciano cfac0fa
Adiciona 'full_tag'
Rossi-Luciano 626fdd3
Aplica formatação
Rossi-Luciano df03ab3
Corrige importações
Rossi-Luciano f919184
Corrige e adiciona 'docstring'
Rossi-Luciano c1a45b2
Remove validação de atributos (substituída pela validação de ordem)
Rossi-Luciano 2d946ec
Adiciona 'validate_history_date'
Rossi-Luciano fdc7e89
Adiciona validação de ordem dos atributos
Rossi-Luciano 3d347e6
Adiciona validação de DOI
Rossi-Luciano 4d373d3
Adiciona 'validate'
Rossi-Luciano 47c4598
Adiciona 'validate_related_article_matches_article_type'
Rossi-Luciano cbb03fe
Adapta testes de artigos relacionados
Rossi-Luciano e324186
Adapta testes de 'errata'
Rossi-Luciano 5946418
Adapta testes de 'preprint'
Rossi-Luciano aeea305
Merge branch 'master' into feat_realated_article_validation
Rossi-Luciano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ def related_article_attributes_validation(self, error_level="ERROR"): | |
for attrib in ("related-article-type", "id", "href", "ext-link-type"): | ||
if not related_article[attrib]: | ||
yield format_response( | ||
title='Related article type validation', | ||
title='Related article attributes validation', | ||
parent=related_article.get("parent"), | ||
parent_id=related_article.get("parent_id"), | ||
parent_article_type=related_article.get("parent_article_type"), | ||
|
@@ -156,28 +156,3 @@ def related_article_attributes_validation(self, error_level="ERROR"): | |
data=related_article, | ||
error_level=error_level | ||
) | ||
|
||
def related_articles_matches_history_date_validation(self, correspondence_list=None, error_level="ERROR"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Rossi-Luciano isso está sendo atendido em outra classe? Era um questionamento There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, @robertatakenaka |
||
if not correspondence_list: | ||
raise ValidationRelatedArticleException("Function requires a dictionary with article type and history date event") | ||
|
||
for related_article in self.related_articles: | ||
expected_event = correspondence_list.get(self.article_type) | ||
obtained_events = self.history_events | ||
is_valid = expected_event in obtained_events | ||
yield format_response( | ||
title='Related article type validation', | ||
parent=related_article.get("parent"), | ||
parent_id=related_article.get("parent_id"), | ||
parent_article_type=related_article.get("parent_article_type"), | ||
parent_lang=related_article.get("parent_lang"), | ||
item='date', | ||
sub_item='@date-type', | ||
validation_type='exist', | ||
is_valid=is_valid, | ||
expected=expected_event, | ||
obtained=obtained_events, | ||
advice=f"Provide {expected_event} event in <history>", | ||
data=related_article, | ||
error_level=error_level | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rossi-Luciano gostaria que o título não tivesse validation para deixar mais curto, pois tudo é validation. Em title deixe mais específico que aspecto está sendo validado. Neste caso, use f'Related article {attrib}'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, @robertatakenaka