Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the postgres package to version 3.0.0 #71

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

BreX900
Copy link
Contributor

@BreX900 BreX900 commented Nov 8, 2023

  • You no longer need to use the Database class, you can use Connection.open or Pool directly.
  • Database class implements postegres Session and SessionExecutor classes
  • Extension methods for accessing repositories now extend Session
  • Added the ability to create a Pool for your database

BREAKING CHANGES

  • Updated the postgres package to version 3.0.0. To visit all the breaking changes see their changelog
  • Removed Database.query method in favour of Session.execute method
  • Action and Query now accept a Session
  • Repository methods are no longer wrapped in a transaction
  • Removed all fields and methods to execute a transaction in favor of SessionExecutor.runTx

Blocked by #70

Fixs #69 #5

@BreX900
Copy link
Contributor Author

BreX900 commented Jan 8, 2024

@schultek Is there any possibility to merge the PR or is the repo no longer maintained?

@schultek
Copy link
Owner

schultek commented Jan 12, 2024

Sry I haven't been showing much love to the package. I try to review the PR over the next days and get back to working on it some more.

And thanks for the PR.

@BreX900 BreX900 force-pushed the feature/postgres_3 branch from d7c130b to 98cdd91 Compare January 14, 2024 15:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (04933b7) 63.90% compared to head (51f3808) 62.45%.

Files Patch % Lines
lib/src/core/database.dart 38.70% 38 Missing ⚠️
lib/src/cli/migration/patcher.dart 37.50% 10 Missing ⚠️
lib/src/internals/insert_repository.dart 40.00% 3 Missing ⚠️
lib/src/builder/generators/insert_generator.dart 66.66% 2 Missing ⚠️
lib/src/internals/text_encoder.dart 33.33% 2 Missing ⚠️
lib/src/internals/base_repository.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   63.90%   62.45%   -1.45%     
==========================================
  Files          37       37              
  Lines        1507     1505       -2     
==========================================
- Hits          963      940      -23     
- Misses        544      565      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@schultek schultek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your effort

@schultek schultek merged commit b30e92f into schultek:main Feb 5, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants