Skip to content

Commit

Permalink
Revert "luci-proto-ppp: pppoe.so has no MTU option; remove it"
Browse files Browse the repository at this point in the history
This reverts commit 995d3a1.

The `mtu` option controls the pppd mru and mtu arguments, it is not
specific to pppoe.so.

Signed-off-by: Jo-Philipp Wich <[email protected]>
  • Loading branch information
jow- committed May 13, 2024
1 parent b4d3401 commit b57c6ff
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ return network.registerProtocol('pppoe', {
o.placeholder = '0';
o.datatype = 'uinteger';

/* pppoe.so has no MTU option - only underlying device MTU is possible */
o = s.taboption('advanced', form.Value, 'mtu', _('Override MTU'));
o.placeholder = dev ? (dev.getMTU() || '1500') : '1500';
o.datatype = 'max(9200)';
}
});

0 comments on commit b57c6ff

Please sign in to comment.