Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language override feature #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add language override feature #349

wants to merge 1 commit into from

Conversation

L1Q
Copy link
Contributor

@L1Q L1Q commented Oct 12, 2020

Hopefully resolves #228

  • refactor Messages.js
  • expose refreshLang for easy translations reloading
  • update settings version with new setting
  • update settings page with new option
  • make all pages refresh language before rendering

No need to reload extension!
P.S.: hacktoberfest tag or label much appreciated

- refactor Messages.js
- expose refreshLang for easy translations reloading
- update settings version with new setting
- update settings page with new option
- make all pages refresh language before rendering
@schmich
Copy link
Owner

schmich commented Oct 13, 2020

Awesome, this looks promising.

One issue: Messages.js is actually dynamically generated from messages.json (see Makefile and this script). My fault for not putting a banner at the top of Messages.js saying that it was generated by a tool. In general, I'd like to not have to maintain message IDs in multiple places.

Hacktoberfest label applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to explicitly choose extension language
2 participants