Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for paper #378

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

Unit tests for paper #378

wants to merge 48 commits into from

Conversation

Domino2357
Copy link
Contributor

No description provided.

@Domino2357 Domino2357 marked this pull request as ready for review April 20, 2021 11:16
@Domino2357 Domino2357 marked this pull request as draft April 20, 2021 11:16
Domino2357 and others added 18 commits April 20, 2021 13:21
@Domino2357
SciViewTests: added 3 new tests.
3f2937a
@Domino2357
SciViewTest: added a new test.
0a24fbc
@Domino2357
SciViewTests: added a new test alongside a corresponding mock file.
00d9e78
@Domino2357
SciViewTests: added test for a trahsed volume file, doesn't work so far.
3421740
@Domino2357
SciViewTests: added a new test.
d690f9a
@Domino2357
SviView: added Null-safety for centerOnPosition.
c60970a
@Domino2357
Added small volume data set for testing purposes
d18edcb
@Domino2357
LineTests: created new testclass for the 3D line.
ae4bc7e
@Domino2357
LineTests: renamed to Line3DTests
8aa25e1
@Domino2357
SciViewTest: added some new tests, still need revision, though.
e1188c0
@Domino2357
SciViewTest: removed non-applicable test
05d95cf
@Domino2357
Added MeshConverterTests.kt
b880f74
@Domino2357
Line3DTests: made a new one in another directory.
b34fce0
@Domino2357
SciViewTests: converted the SciViewTest class to Kotlin, can not test…
c5f4814 
… it yet due to the project error.
@Domino2357
SviViewTests: deleted comments.
4201b1d
@Domino2357
Line3D: corrected test.
c73eee1
@Domino2357
MeshConverterTests: finished test
4b8d3ab
@Domino2357
Added new test for DisplayWindow
fd956e5
Domino2357 and others added 20 commits April 27, 2021 18:25
@Domino2357
Added test for SwingMainWindow
e1a230a
@Domino2357
Added a new test for SwingNodePropertyEditor
27bee25
@Domino2357
Added TaskManagerTests
968c04e
@Domino2357
added ControlPointTests
f811800
@Domino2357
ControlPointTests: added new tests
54777da
@Domino2357
Added new test.
ad5ee85
@Domino2357
Added new test for Ruler
d77baa4
@Domino2357
Deleted deprecated files and added some blank lines
83d608a
@Domino2357
Wrote a new test for SciView.
9329d34
@Domino2357
Deleted SciViewTest.java as a new version with kotlin exists.
e90bd08
@Domino2357
Added 'System.setProperty('java.awt.headless', 'false')' to hopefully…
87aec7f 
… prevent build from breaking.
@Domino2357
up
154b81b
@Domino2357
up
513a219
@Domino2357
up
0e6f7b7
@Domino2357
up
0ef0e16
@Domino2357
Merge branch 'master' into unitTestsForPaper
4fdcf66
@elect86
Test CI
08c5b0a
@elect86
Merge remote-tracking branch 'origin/unitTestsForPaper' into unitTest…
b801e7f 
…sForPaper
@elect86
Gradle 7.0
98bd723
@Domino2357
Merge branch 'master' into unitTestsForPaper
06f8893 
merge to fix the CI
@kephale
Copy link
Member

kephale commented Jul 16, 2023

@Domino2357 @skalarproduktraum what is the plan with this PR?

@Domino2357
Copy link
Contributor Author

@kephale Thanks for the note! When I was starting, Ulrik asked me to write some unit tests for the sciview paper. Those are the first tests I wrote. However, the task trickled down the priority list afterward.
Would a few (basic) tests still be useful for sciview? Otherwise, there is no need to keep it imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Domino2357 @kephale @elect86