Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table and list with a container around for overflow #4571

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Dec 11, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

  • Add a container around List and Table to handle overflow X with a scroll. If not the table and list are overflowing their parents which is not good.
  • Add columns into the provider so we can set width, min-width and max-width to each td in the table. Not only for the th. This enforce consistent aspect of the table / list.

@matthprost matthprost added the bug Something isn't working label Dec 11, 2024
@matthprost matthprost requested a review from a team December 11, 2024 08:47
@matthprost matthprost self-assigned this Dec 11, 2024
@matthprost matthprost requested review from johnrazeur and DorianMaliszewski and removed request for a team December 11, 2024 08:47
@matthprost matthprost requested a review from lisalupi as a code owner December 11, 2024 08:47
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 6cea019

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (e11aa60) to head (6cea019).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4571      +/-   ##
==========================================
+ Coverage   87.51%   87.54%   +0.02%     
==========================================
  Files         335      335              
  Lines       12762    12785      +23     
  Branches     3510     3477      -33     
==========================================
+ Hits        11169    11192      +23     
  Misses       1593     1593              
Files with missing lines Coverage Δ
packages/ui/src/components/List/ListContext.tsx 96.82% <ø> (ø)
packages/ui/src/components/List/Row.tsx 92.66% <100.00%> (+0.74%) ⬆️
packages/ui/src/components/List/SkeletonRows.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/List/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Table/Row.tsx 76.25% <100.00%> (+3.39%) ⬆️
packages/ui/src/components/Table/TableContext.tsx 90.09% <ø> (ø)
packages/ui/src/components/Table/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9bc84...6cea019. Read the comment docs.

@matthprost matthprost merged commit 7633f1f into main Dec 11, 2024
14 checks passed
@matthprost matthprost deleted the fix/table-list-container branch December 11, 2024 14:17
@scaleway-bot scaleway-bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants