Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devdeps): update node.js to v22.12.0 #4557

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore(devdeps): update node.js to v22.12.0 #4557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM node:22.11.0-alpine
FROM node:22.12.0-alpine
WORKDIR /build

ARG TURBO_TOKEN=token

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / deploy

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "TURBO_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

ENV TURBO_TOKEN ${TURBO_TOKEN}

Check warning on line 6 in Dockerfile

View workflow job for this annotation

GitHub Actions / deploy

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 6 in Dockerfile

View workflow job for this annotation

GitHub Actions / deploy

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "TURBO_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

COPY . .

Expand All @@ -13,4 +13,4 @@

EXPOSE 80/tcp

CMD pnpm http-server ./storybook-static -p 80

Check warning on line 16 in Dockerfile

View workflow job for this annotation

GitHub Actions / deploy

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Loading