Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxlint): add oxlint config #4520

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(oxlint): add oxlint config #4520

merged 1 commit into from
Nov 29, 2024

Conversation

philibea
Copy link
Collaborator

@philibea philibea commented Nov 28, 2024

Summary

Type

  • Enhancement

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 28988fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 84.52381% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c3ee88b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/SelectInputV2/SelectInputProvider.tsx 42.85% 4 Missing ⚠️
...ages/ui/src/components/Modal/components/Dialog.tsx 33.33% 2 Missing ⚠️
packages/ui/src/components/Popup/index.tsx 80.00% 1 Missing ⚠️
...kages/ui/src/components/SelectInputV2/Dropdown.tsx 50.00% 1 Missing ⚠️
...src/components/SelectInputV2/SearchBarDropdown.tsx 0.00% 1 Missing ⚠️
...rc/components/SelectInputV2/findOptionInOptions.ts 0.00% 1 Missing ⚠️
.../src/components/Slider/components/DoubleSlider.tsx 66.66% 1 Missing ⚠️
.../src/components/Slider/components/SingleSlider.tsx 50.00% 1 Missing ⚠️
packages/ui/src/mocks/list.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4520   +/-   ##
=======================================
  Coverage        ?   87.40%           
=======================================
  Files           ?      334           
  Lines           ?    12588           
  Branches        ?     3429           
=======================================
  Hits            ?    11002           
  Misses          ?     1586           
  Partials        ?        0           
Files with missing lines Coverage Δ
.../src/components/DateField/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...ckages/form/src/components/KeyValueField/index.tsx 94.11% <ø> (ø)
packages/form/src/components/ToggleField/index.tsx 58.82% <ø> (ø)
...ages/form/src/validators/__tests__/maxDate.test.ts 100.00% <100.00%> (ø)
...ages/form/src/validators/__tests__/minDate.test.ts 100.00% <100.00%> (ø)
.../ui/src/components/Breadcrumbs/components/Item.tsx 100.00% <ø> (ø)
...i/src/components/Checkbox/__tests__/index.test.tsx 68.65% <100.00%> (ø)
.../src/components/DateInput/__tests__/helper.test.ts 100.00% <100.00%> (ø)
packages/ui/src/components/DateInput/index.tsx 98.71% <100.00%> (ø)
...kages/ui/src/components/LineChart/CustomLegend.tsx 100.00% <ø> (ø)
... and 25 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ee88b...28988fd. Read the comment docs.

@philibea philibea force-pushed the oxlint-config branch 5 times, most recently from 2125c46 to 7e326ce Compare November 29, 2024 09:50
Signed-off-by: Alexandre Philibeaux <[email protected]>
@philibea philibea merged commit a57bf0c into main Nov 29, 2024
15 checks passed
@philibea philibea deleted the oxlint-config branch November 29, 2024 14:11
@philibea philibea restored the oxlint-config branch November 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants