Skip to content

Commit

Permalink
chore(oxlint): update config
Browse files Browse the repository at this point in the history
Signed-off-by: Alexandre Philibeaux <[email protected]>
  • Loading branch information
philibea committed Dec 10, 2024
1 parent a0ba96a commit 5e9fd3c
Show file tree
Hide file tree
Showing 87 changed files with 192 additions and 194 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm exec manypkg check
typecheck:
runs-on: ubuntu-24.04
Expand All @@ -39,7 +39,7 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm typecheck
oxlint:
Expand All @@ -56,9 +56,9 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm build
pnpm oxlint -c .oxlintrc.json
pnpm oxlint -c .oxlintrc.json --quiet
lint:
runs-on: ubuntu-24.04
Expand All @@ -74,7 +74,7 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm build
pnpm run lint
Expand All @@ -92,7 +92,7 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm run format:ci
test:
Expand All @@ -115,7 +115,7 @@ jobs:
node-version: ${{ matrix.node }}
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm run test:unit:coverage
- uses: codecov/[email protected]
with:
Expand Down Expand Up @@ -156,7 +156,7 @@ jobs:
with:
node-version: ${{ matrix.node }}
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm run build
publint:
Expand All @@ -173,7 +173,7 @@ jobs:
node-version: 22
cache: "pnpm"
- run: |
pnpm install
pnpm install --frozen-lockfile
pnpm publint
deploy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fonts-upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
node-version: 22
cache: "pnpm"
- run: pnpm install
- run: pnpm install --frozen-lockfile

- name: Install aws CLI
run: |
Expand Down
40 changes: 17 additions & 23 deletions .oxlintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,42 +2,46 @@
"$schema": "./node_modules/oxlint/configuration_schema.json",
"categories": {
"correctness": "error",
"style": "error",
"suspicious": "error",
"perf": "error",
"nursery": "off",
"pedantic": "error",
"perf": "error",
"restriction": "error",
"nursery": "off"
"style": "error",
"suspicious": "error"
},
"plugins": [
"import",
"n",
"node",
"react",
"react-perf",
"react",
"security",
"n",
"tree_shaking",
"typescript",
"unicorn",
"vitest"
"unicorn"
],
"overrides": [
{
"files": ["**/__stories__/**/*.{ts,tsx}"],
"files": ["**/__stories__/**/*.{ts,tsx}", "**/__tests__/**/*.{ts,tsx}"],
"rules": {
"react/jsx-key": "off",
"no-console": "off",
"no-alert": "off"
}
},
{
"files": ["**/__tests__/**/*.{ts,tsx}", "setup.ts"],
"plugins": ["vitest"]
}
],
"rules": {
"@typescript-eslint/ban-tslint-comment": "off",
"@typescript/no-explicit-any": "warn",
"@typescript-eslint/no-unused-expressions": "warn",
"@typescript-eslint/ban-tslint-comment": "warn",
"@typescript-eslint/consistent-indexed-object-style": "error",
"@typescript-eslint/consistent-type-definitions": ["error", "type"],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript/no-explicit-any": "warn",
"@typescript-eslint/prefer-enum-initializers": "off",
"@typescript-eslint/prefer-function-type": "off",
"@typescript-eslint/prefer-literal-enum-member": "off",
Expand All @@ -49,10 +53,8 @@
"eslint/no-empty-function": "off",
"eslint/no-magic-numbers": "off",
"eslint/no-ternary": "off",
"eslint/no-undef": "off",
"eslint/no-undefined": "off",
"eslint/sort-keys": "off",
"eslint/react-in-jsx-scope": "off",
"eslint/no-unused-vars": [
"error",
{
Expand All @@ -67,26 +69,18 @@
"memberSyntaxSortOrder": ["single", "multiple", "all", "none"]
}
],
"import/export": "off",
"import/import-no-namespace": "off",
"eslint/yoda": "error",
"import/no-namespace": "off",
"import/max-dependencies": "off",
"import/namespace": "off",
"import/no-default-export": "off",
"import/no-deprecated": "warn",
"import/no-duplicates": "off",
"import/no-unused-modules": "off",
"import/unambiguous": "warn",
"oxc/no-accumulating-spread": "off",
"oxc/no-async-await": "off",
"oxc/no-barrel-file": "off",
"oxc/no-optional-chaining": "off",
"oxc/no-rest-spread-properties": "off",
"react-perf/jsx-no-jsx-as-prop": "off",
"react-perf/jsx-no-new-array-as-prop": "off",
"react-perf/jsx-no-new-function-as-prop": "off",
"react-perf/jsx-no-new-object-as-prop": "off",
"react/jsx-no-useless-fragment": "off",
"react/exhaustive-deps": "warn",
"react/iframe-missing-sandbox": "warn",
"react/jsx-no-target-blank": "off",
"react/react-in-jsx-scope": "off",
Expand Down
1 change: 1 addition & 0 deletions biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
},
"files": {
"ignore": [
".turbo/",
".next/",
"coverage/",
"**/node_modules/",
Expand Down
2 changes: 1 addition & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,5 @@ export default [
],
...testingLibrary.configs['flat/react'],
},
oxlint.configs['flat/all'],
...oxlint.buildFromOxlintConfigFile('.oxlintrc.json'),
]
5 changes: 2 additions & 3 deletions expect.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import 'expect'

declare module 'expect' {
interface Matchers<R extends void | Promise<void>, T = unknown>
extends jest.Matchers<R, T> {
type Matchers<R extends void | Promise<void>, T = unknown> = {
toHaveNoViolations(): R
}
} & jest.Matchers<R, T>
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
"emoji-toolkit": "9.0.1",
"esbuild-plugin-browserslist": "0.15.0",
"eslint": "9.16.0",
"eslint-plugin-oxlint": "0.14.1",
"eslint-plugin-oxlint": "0.15.0",
"eslint-plugin-testing-library": "7.1.1",
"expect": "29.7.0",
"file-loader": "6.2.0",
Expand All @@ -165,7 +165,7 @@
"identity-obj-proxy": "3.0.0",
"jest-axe": "9.0.0",
"lint-staged": "15.2.11",
"oxlint": "0.13.2",
"oxlint": "0.15.0",
"postcss": "8.4.49",
"publint": "0.2.12",
"react": "18.3.1",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, renderHook, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test, vi } from 'vitest'
import { DateField } from '..'
Expand Down
2 changes: 1 addition & 1 deletion packages/form/src/components/Form/__tests__/index.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test, vi } from 'vitest'
import { NumberInputField } from '../..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, fireEvent, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test, vi } from 'vitest'
import { SelectInputFieldV2 } from '..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test, vi } from 'vitest'
import { SelectableCardField } from '../..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { act, fireEvent, renderHook, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test } from 'vitest'
import { Submit, TextInputField } from '../..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm } from '@utils/test'
import { describe, expect, test, vi } from 'vitest'
import { Submit, SubmitErrorAlert } from '../..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm } from '@utils/test'
import { describe, expect, test } from 'vitest'
import { TextInputField } from '..'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { mockFormErrors, renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { renderHook, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithForm, renderWithTheme } from '@utils/test'
import { useForm } from 'react-hook-form'
import { describe, expect, test, vi } from 'vitest'
Expand Down
2 changes: 1 addition & 1 deletion packages/plus/src/components/CodeEditor/CodeEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type { ComponentProps } from 'react'
const StyledText = styled(Text)`
background-color: ${({ theme }) => theme.colors.neutral.backgroundStrong};
padding: ${({ theme }) => `${theme.space['1']} ${theme.space['2']}`};
border-radius: ${({ theme }) => theme.radii.default};
border-radius: ${({ theme }) => `${theme.radii.default}`};
width: 100%;
`

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithTheme } from '@utils/test'
import { describe, expect, it, vi } from 'vitest'
import { CustomerSatisfaction } from '..'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,7 @@ type ItemProps = {
| 'months'
| 'years'
// Allow a string for unit but keep autocomplete for the above values
// oxlint-disable-next-line typescript-eslint(ban-types)
| (string & {})
| (string & NonNullable<unknown>)
}

const StyleNoPriceItem = styled(Text)`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithTheme, shouldMatchEmotionSnapshot } from '@utils/test'
import {
resetIntersectionMocking,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithTheme, shouldMatchEmotionSnapshot } from '@utils/test'
import {
resetIntersectionMocking,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { screen, waitFor } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { renderWithTheme, shouldMatchEmotionSnapshot } from '@utils/test'
import {
resetIntersectionMocking,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { fireEvent, screen } from '@testing-library/react'
import userEvent from '@testing-library/user-event'
import { userEvent } from '@testing-library/user-event'
import { blockStorageWire } from '@ultraviolet/illustrations/products/blockStorage'
import { renderWithTheme, shouldMatchEmotionSnapshot } from '@utils/test'
import { describe, expect, it, test } from 'vitest'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// eslint-disable no-bitwise
// Function imported from https://github.com/PimpTrizkit/PJs/wiki/12.-Shade,-Blend-and-Convert-a-Web-Color-(pSBC.js)#stackoverflow-archive-begin to shade hexa colors
// oxlint-disable no-bitwise

type ShadeHexColorType = (color: string, percent: number) => string

Expand Down
Loading

0 comments on commit 5e9fd3c

Please sign in to comment.