Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/SK-1060 | Move mnist data to scaleout public bucket #712

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Wrede
Copy link
Member

@Wrede Wrede commented Sep 26, 2024

This pull request includes significant changes to the data handling and dependencies in the examples/mnist-pytorch/client project. The most important changes involve replacing the use of torchvision with direct data downloads, updating the data loading logic, and modifying the environment dependencies.

Data Handling Improvements:

Dependency Updates:

@Wrede Wrede requested a review from ahellander September 26, 2024 13:47
Copy link
Member

@ahellander ahellander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good general improvement, although it reduces the flexibility a bit (max 10 splits possible).

But you need to update the getting started guide as well, e.g. remove the FEDN_NUM_DATA_SPLITS env variable.

Not needed now ,but I think for pedagogical reasons it would also be good to add the option to first download the data split, then start the client. But this could be done later.

@Wrede Wrede added the HOLD label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants