Feature/SK-521 | Global model not created if the combiner terminates based on timeout #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrede
changed the title
Wrede
requested changes
Oct 20, 2023
There was a problem hiding this comment.
I really like the "status" update to rounds. We should also add session_id as a field in rounds in statestore. Regarding the implementation of round, it's quite hard to read, I would say one reason for this are the nested functions. I have added many comments, also please add docs strings, we want to have a complete API ref for v1.0
|
@ahellander can you please write a better description of the PR, with more information what in introduces/fixes? |
|
Ok, I have updated the message. |
Wrede
approved these changes
Nov 9, 2023
| round_data['round_config'] = round_config | ||
| # Wait until participating combiners have produced an updated global model, | ||
| # or round times out. | ||
| def do_if_round_times_out(result): |
There was a problem hiding this comment.
@ahellander why wouldn't the library be able to use functions in the global scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrites some of the polling in the controller in a more robust way. Increases robustness and removes risks of race condition when combiner times out.